canonical / canonical/layer-basic

Improve series upgrade handling by allowing for manual venv rebuild

Open
#158 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
10
Forks
42
PR merge metrics
No merged PRs in 30d

Description

It is likely that an admin will want to validate that the charm code will be successful after a series upgrade before issuing the `juju upgrade-series complete` command. However, the [current logic](https://github.com/juju-solutions/layer-basic/blob/master/lib/charms/layer/basic.py#L116-L119) will [only trigger on the `post-series-upgrade` hook](https://github.com/juju-solutions/layer-basic/blob/master/lib/charms/layer/basic.py#L102) which doesn't allow the admin a chance to validate the new venv.

I think we should add a `--rebuild` option to the [`charm-env` command](https://github.com/juju-solutions/layer-basic/blob/master/bin/charm-env) which does the venv rebuild manually and presumably sets a flag to indicate to the bootstrap code that it has already been rebuilt for the current series so that it doesn't get rebuilt again upon `post-series-upgrade`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.