callstack / callstack/react-theme-provider

Something is definitely wrong with <ThemeProvider>'s typings 👀

Open
#139 1 comment 12 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
467
Forks
53
PR merge metrics
No merged PRs in 30d

Description

## Description

image

BTW i don't really understand what for this component is needed
Everything seems to work fine even without it

withTheme() HOC kinda provides theming 🤷🏼‍♂️


## Reproducible Demo

I've reproduced this issue on CodeSandbox
Come check that out 👇

[sandbox 🎁](https://codesandbox.io/s/theme-provider-issue-n602nb)

Contributor guide

Open the contributing guide

Research direction

Start with the linked CodeSandbox reproduction and inspect the ThemeProvider typings and usage shown there. Confirm which typing behavior is incorrect and define the expected ThemeProvider usage before changing anything; the issue is done when the reproduction no longer reports the typing problem.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.