callstack / callstack/react-native-slider

Support native events

Aperta
#99 8 commenti 9 reazioni 0 assegnatari Vedi su GitHub
feature request
Lingua principale
TypeScript
Stelle
1.4k
Fork
295
Merge medio
5m
PR unite (30g)
1

Descrizione

## Describe the Feature

**Native Events** instead of ~js events~:
`onValueChange`
`onSlidingStart`
`onSlidingComplete`

## Possible Implementations

Supporting **native events** will unlock the abilities of `Animated.event` enabling tracking the Slider's value and animating stuff accordingly.
This will enable customizing this view to a large extent easily and with high performance.

Avoiding breaking changes can be achieved with a flag from props or by checking `typeof props.onValueChange === 'object'`

.
### Android JS Impl
Uses `Slider` for `value` and renders the rest on top.
Native events will enhance this extremely and make *dev experience* easier (less code needed for customization)

![Color Slider](https://user-images.githubusercontent.com/34343793/63846964-83cbea80-c995-11e9-90d1-e388e9bb3561.gif)

## Related Issues

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.