callstack / callstack/react-native-slider
feat(android): add disableAndroidRipple prop to remove SeekBar ripple
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 295
- Avg merge
- 5m
- Merged PRs (30d)
- 1
Description
## Problem
On Android the slider uses the native SeekBar which draws a platform ripple around the thumb when pressed. There is currently no supported way to disable or customize this ripple from JS. That prevents apps from implementing custom thumb overlays or matching certain visual designs without editing native code or changing app themes.
## Proposal
Add an opt-in boolean prop `disableAndroidRipple` (default: false) on Android that removes background/foreground ripple/state animator on the native SeekBar. This should be non-breaking (opt-in) and implemented defensively for OEM quirks / API levels.
## Example usage
```jsx
Contributor guide
Research direction
Start by locating the Slider's Android native SeekBar entry point and the existing JS prop definitions. Verify how background, foreground ripple, and state animator behavior varies across Android API levels, then confirm that the new prop defaults to false, disables the ripple when enabled, and preserves existing behavior otherwise.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, react-native
- Domain
- mobile-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100