callstack / callstack/react-native-paper
refactor(dialog): improve composition model and accessibility
- Dominant language
- TypeScript
- Stars
- 14.5k
- Forks
- 2.2k
- Avg merge
- 5d 23h
- Merged PRs (30d)
- 12
Description
Refactor Dialog to improve Material Design 3 compliance, remove problematic children patterns, improve performance characteristics, and modernize the public API.
**Problems**
- Current API relies heavily on children composition in ways that are difficult to optimize
- Internal layout logic is tightly coupled to arbitrary child structures
- MD3 behaviors and visuals are not fully aligned with current Material guidelines
- Rendering performance can degrade in large lists or frequently updated screens
- Type safety and discoverability of the API can be improved
- The component has inconsistent behavior between platforms and edge cases
**Focus Areas**
- Simplify Dialog.Title / Dialog.Content / Dialog.Actions hierarchy
- Improve keyboard and accessibility handling
- Improve MD3 spacing and tonal elevation
- Reduce excessive wrappers
**Proposed API Direction**
``
**Performance Opportunities**
- Reduce nested layout complexity
- Improve portal interaction handling
- Reduce unnecessary rerenders during visibility updates
Contributor guide
Research direction
Start by locating the Dialog component and reviewing its current children-based composition, portal behavior, and visibility updates. Compare the existing public API with the proposed title, content, and actions props, then assess the keyboard, accessibility, MD3 spacing, tonal elevation, and wrapper changes. Done means a coherent API and consistent behavior across the stated platforms and edge cases, with improved rendering characteristics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- accessibility, design, frontend, mobile, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100