callstack / callstack/react-native-paper

Expose adjustsFontSizeToFit as new prop for Button

Ouverte
#4,854 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Button feature request
Langage dominant
TypeScript
Étoiles
14.5k
Forks
2.2k
Merge moyen
5 j 23 h
PR mergées (30 j)
12

Description

**Is your feature request related to a problem? Please describe.**
On some devices button text gets truncated due to `numberOfLines={1}` being applied to the `Text` label.

**Describe the solution you'd like**
`adjustsFontSizeToFit` exists and provides an easy way to keep the entire label visible.

**Describe alternatives you've considered**
I have attempted to do this myself by passing a `Text` element as a child to the button like so:
```


{text}

```
This unfortunately did not work. Only by editing the `Button` itself did iOS respect the `adjustsFontSizeToFit` prop.
**Additional context**
It looks like there is an existing pull request for this (although it's missing context):
#4125

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start at the Button implementation that renders the Text label, then review the context of pull request #4125. Expose adjustsFontSizeToFit as a Button prop and verify that the label remains visible on iOS when the text would otherwise be truncated.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
react-native, typescript
Domaine
mobile
Type d'issue
Fonctionnalité
Difficulté
2/5
Temps estimé
1-3 heures
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
55/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.