callstack / callstack/react-native-paper
Menu onDismiss Animation
- 主要语言
- TypeScript
- 星标
- 14.5k
- 派生
- 2.2k
- 平均合并
- 5 天 23 小时
- 30 天内合并 PR
- 12
描述
**Is your feature request related to a problem? Please describe.**
Some of the menu component's onDismiss handling ([1](https://github.com/callstack/react-native-paper/blob/ff0df5454eb13d6e8e2d8f1c87c0bca8bb3635f0/src/components/Menu/Menu.tsx#L643),[2](https://github.com/callstack/react-native-paper/blob/ff0df5454eb13d6e8e2d8f1c87c0bca8bb3635f0/src/components/Menu/Menu.tsx#L654)) does NOT call hide(); if I change the menu's visibility within ondismiss it cancels the animation entirely
**Describe the solution you'd like**
[make hide accepts a callback](https://github.com/lovegaoshi/azusa-player-mobile/blob/2648f55f4cb6c6dd72433a871a63249cbed79d1e/patches/react-native-paper%2B5.14.5.patch#L18), calls the callback at the end of the animation, and replace the onDismiss to `() => hide(onDismiss)`
**Describe alternatives you've considered**
I might have totally missed the memo on how to control the menu visibility via onDismiss.
**Additional context**
Add any other context or screenshots about the feature request here.
贡献指南
调研方向
从 src/components/Menu/Menu.tsx 开始,重点检查与第 643 行和第 654 行附近相关的 onDismiss 处理,并检查现有的隐藏动画流程。完成标准是:dismiss 回调在动画完成后运行,并且从 onDismiss 更改可见性不再取消该动画。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react-native, typescript
- 领域
- mobile
- Issue 类型
- 功能
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 55/100