callstack / callstack/react-native-paper

BottomNavigation.Bar applies wrong fontWeight to active label

Offen
#4,780 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
TypeScript
Sterne
14.5k
Forks
2.2k
Ø Merge
5 T. 23 Std.
Gemergte PRs (30 T.)
12

Beschreibung

### Current behaviour
The `BottomNavigation.Bar` applies the same `fontWeight` to all labels (active and inactive) as seen [in the implementation](https://github.com/callstack/react-native-paper/blob/ff0df5454eb13d6e8e2d8f1c87c0bca8bb3635f0/src/components/BottomNavigation/BottomNavigationBar.tsx#L850) but according to the [MD3 spec](https://m3.material.io/components/navigation-bar/specs) the weight for the active label should be bold (i.e. 700).

### Expected behaviour
Active label should be bold.

### How to reproduce?
Use `BottomNavigation.Bar` (e.g. together with react-navigation).

### Preview

### What have you tried so far?

Read the implementation, which clearly is wrong.

### Your Environment

| software | version
| --------------------- | -------
| ios | x
| android | x
| react-native | x.x.x
| react-native-paper | 5.14.5
| node | x.x.x
| npm or yarn | x.x.x
| expo sdk | x.x.x

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.