callstack / callstack/react-native-paper
Menu appearing behind other components
- 主要语言
- TypeScript
- 星标
- 14.5k
- 派生
- 2.2k
- 平均合并
- 5 天 23 小时
- 30 天内合并 PR
- 12
描述
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used [patch-package](https://github.com/ds300/patch-package) to patch `react-native-paper@5.14.5` for the project I'm working on.
**Problem:** Menu was appearing behind other components.
Before:
After:
Here is the diff that solved my problem:
```diff
diff --git a/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts b/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts
index de236cc..feeba5f 100644
--- a/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts
+++ b/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts
@@ -5,6 +5,7 @@ export type Props = {
children: React.ReactNode;
theme?: ThemeProp;
settings?: Settings;
+ style?: StyleProp;
};
declare const PaperProvider: (props: Props) => React.JSX.Element;
export default PaperProvider;
diff --git a/node_modules/react-native-paper/src/core/PaperProvider.tsx b/node_modules/react-native-paper/src/core/PaperProvider.tsx
index 51839a5..d8f1a16 100644
--- a/node_modules/react-native-paper/src/core/PaperProvider.tsx
+++ b/node_modules/react-native-paper/src/core/PaperProvider.tsx
@@ -4,6 +4,8 @@ import {
Appearance,
ColorSchemeName,
NativeEventSubscription,
+ StyleProp,
+ ViewStyle,
} from 'react-native';
import SafeAreaProviderCompat from './SafeAreaProviderCompat';
@@ -18,6 +20,7 @@ export type Props = {
children: React.ReactNode;
theme?: ThemeProp;
settings?: Settings;
+ style?: StyleProp;
};
const PaperProvider = (props: Props) => {
@@ -109,7 +112,7 @@ const PaperProvider = (props: Props) => {
);
return (
-
+
{children}
```
This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).
贡献指南
调研方向
从 src/core/PaperProvider.tsx 开始,将其 Props 声明与生成的 lib/typescript/core/PaperProvider.d.ts 文件进行比较。重现 issue 中所示的菜单层叠问题,并验证 provider 的样式更改是否使菜单显示在其他组件之上;报告中未指定测试文件。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react-native, typescript
- 领域
- frontend, mobile
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 48/100