callstack / callstack/react-native-paper

Menu appearing behind other components

Open
#4,770 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14.5k
Forks
2.2k
Avg merge
5d 23h
Merged PRs (30d)
12

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `react-native-paper@5.14.5` for the project I'm working on.

**Problem:** Menu was appearing behind other components.

Before:
Image

After:
Image

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts b/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts
index de236cc..feeba5f 100644
--- a/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts
+++ b/node_modules/react-native-paper/lib/typescript/core/PaperProvider.d.ts
@@ -5,6 +5,7 @@ export type Props = {
children: React.ReactNode;
theme?: ThemeProp;
settings?: Settings;
+ style?: StyleProp;
};
declare const PaperProvider: (props: Props) => React.JSX.Element;
export default PaperProvider;
diff --git a/node_modules/react-native-paper/src/core/PaperProvider.tsx b/node_modules/react-native-paper/src/core/PaperProvider.tsx
index 51839a5..d8f1a16 100644
--- a/node_modules/react-native-paper/src/core/PaperProvider.tsx
+++ b/node_modules/react-native-paper/src/core/PaperProvider.tsx
@@ -4,6 +4,8 @@ import {
Appearance,
ColorSchemeName,
NativeEventSubscription,
+ StyleProp,
+ ViewStyle,
} from 'react-native';

import SafeAreaProviderCompat from './SafeAreaProviderCompat';
@@ -18,6 +20,7 @@ export type Props = {
children: React.ReactNode;
theme?: ThemeProp;
settings?: Settings;
+ style?: StyleProp;
};

const PaperProvider = (props: Props) => {
@@ -109,7 +112,7 @@ const PaperProvider = (props: Props) => {
);

return (
-
+


{children}
```

This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.