callstack / callstack/react-native-paper
apply safe area insets to menu
- Langage dominant
- TypeScript
- Étoiles
- 14.5k
- Forks
- 2.2k
- Merge moyen
- 5 j 23 h
- PR mergées (30 j)
- 12
Description
### Current behaviour
When I have a large component in a Menu, it can go out of the safe-area-view going behind the statusbar and the notch (photos below).
### Expected behaviour
Menu should consider the SafeArea Insets when calculating the available space to show the menu on Top.
### How to reproduce?
Render a large enough component in a Menu and scroll to a point that including the statusbar/notch there's enough space on top of the anchor.
The menu opens on top and goes under the statusbar/notch.
### Preview
iPhone 13 mini:
### What have you tried so far?
Adding SafeArea Top Inset value to the `additionalVerticalValue` calculated here fixes the issue:
https://github.com/callstack/react-native-paper/blob/beab66e074e2b0dfa1251ae221308178003d4a9b/src/components/Menu/Menu.tsx#L447-L451
**Although** after doing this, when the menu opens below the anchor, it has a space from anchor equal to the top-inset, so more changes are needed to correctly apply the insets.
### Your Environment
| software | version
| --------------------- | -------
| ios | 18.1
| android | SDK 34
| react-native | 0.76.9
| react-native-paper | 5.13.3
| node | v22.12.0
| npm or yarn | yarn 4.7.0
| expo sdk | ~52.0.46
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez dans src/components/Menu/Menu.tsx autour des lignes 447-451, où additionalVerticalValue est calculé. Reproduisez le problème avec un composant Menu volumineux sur un iPhone avec encoche, puis vérifiez que les menus qui s’ouvrent au-dessus comme au-dessous de leurs ancres respectent les safe-area insets, sans chevauchement ni espace involontaire.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- react-native, typescript
- Domaine
- frontend, mobile
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 48/100