callstack / callstack/react-native-pager-view

(iOS) Dynamic pages causes page switch when adding pages at the start

Abierto
#965 1 comentario 3 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
3.4k
Forks
476
Merge medio
10 d 21 h
PR fusionados (30 d)
2

Descripción

## Environment

Expo v52
React Native 0.76.6
Expo Router v4
iPhone 16 Pro Simulator

## Description

### Summary

I'm using this pager view to show images (similar to iOS photos app), and since there's a lot of images to be loaded, it's images are loaded as requested, similar to FlatList `onStartReached` and `onEndReached`.

### Current behaviour

Adding pages to the end of the data array works very well, but when adding to the start, the current page changes to the new page added based on the page index it was before.

### Expected behaviour

I can see this might be an intended behaviour based on what is being built, but having at least a prop like `preservePage` to update the current page while preserving the page in view (maybe based on page key or id) would be perfect for dynamically loading pages.

I also tested on Android, and it works as expect most of the times, maintaining the correct current page view. Some times it does not update the `activePage` correctly, but the current page view stay as is.

## Findings

On version `6.5.1` of this library, the current page view is preserved as expected, and after digging deeper, I found out that #923 (introduced on `6.6.0`) is the "culprit" for the issue. Although this makes the current page view still visible, the actual `activePage` is not updated accordingly, which also impacts on the position given by `onPageScroll`. It only correctly updates the `activePage` when completing a swipe to the left/right, then `onPageSelected` is called with the correct position.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Empieza reproduciendo el comportamiento de iOS con páginas antepuestas dinámicamente usando la configuración reportada de Expo v52, React Native 0.76.6 y pager-view 6.6.0. Inspecciona el cambio introducido por #923 y compáralo con la versión 6.5.1; después, verifica que la página visible, activePage y la posición de onPageScroll permanezcan alineados después de añadir páginas al principio.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
ios, react-native, typescript
Área
mobile
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.