callstack / callstack/react-native-pager-view
ViewPager layout breaks when detaching and attaching it again
- Langage dominant
- TypeScript
- Étoiles
- 3.4k
- Forks
- 476
- Merge moyen
- 10 j 21 h
- PR mergées (30 j)
- 2
Description
## Environment info
```sh
react-native: 0.61.5
```
Library version: `3.2.0`
## Steps To Reproduce
See the issue:

## Reproducible sample code
Repro: https://github.com/ferrannp/react-native-viewpager-detach-example
When navigating to another screen with `react-navigation` (e.g to another tab), `onDetachedFromWindow` is called. When we come back to the view that has the `ViewPager`, this code is called:
https://github.com/react-native-community/react-native-viewpager/blob/master/android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPager.java#L212-L219
However, it seems to be called too late and the Pager gets broken. I tried the following solution:
```java
@Override
protected void onAttachedToWindow() {
super.onAttachedToWindow();
// The viewpager reset an internal flag on this method so we need to run another layout pass
// after attaching to window.
this.requestLayout();
// CODE CHANGES BELOW
measure(
MeasureSpec.makeMeasureSpec(getWidth(), MeasureSpec.EXACTLY),
MeasureSpec.makeMeasureSpec(getHeight(), MeasureSpec.EXACTLY));
layout(getLeft(), getTop(), getRight(), getBottom());
}
```
And it works. However, I am not sure this is the best solution. I know @kmagiera did something similar before with Pager so I am just CCing you here. Maybe @satya164 @NoemiRozpara you found this before when working with react-navigation and ViewPager? I'll also CC @ruiaraujo which implemented this piece of code 2 years ago 😄 .
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez par android/src/main/java/com/reactnativecommunity/viewpager/ReactViewPager.java aux lignes indiquées et reproduisez le flux de detach/attach à l’aide du react-native-viewpager-detach-example fourni. Comparez le comportement existant de onAttachedToWindow avec la séquence de measure et de layout signalée ; le travail est terminé lorsque le ViewPager reste correctement positionné après avoir navigué ailleurs puis être revenu.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- android, java, react-native
- Domaine
- mobile-dev
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 38/100