callstack / callstack/react-native-draco

GetAttributeDataArrayForAllPoints: non-float attributes have no conversion or mapping fallback

未关闭
#5 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C++
星标
10
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

## Environment

@callstack/react-native-draco 0.3.0
three's GLTFLoader, RN 0.86, new architecture, iOS

## Description

`cpp/draco-helpers.h` has two extraction paths that behave differently:

- `GetAttributeFloatArrayForAllPoints` (float requests) walks `mapped_index` and falls back to `pa.ConvertValue()` for non-float source data — it handles quantization and non-identity mapping.
- `GetAttributeDataArrayForAllPointsHelper` (every non-float typed request) only succeeds when `pa.data_type() == type` **and** `pa.is_mapping_identity()` — a direct `memcpy`. Any type mismatch or non-identity mapping returns `false` and decode fails. No `ConvertValue` fallback like Draco's Emscripten wrapper.

So Float32 POSITION/NORMAL/TEXCOORD works, but skinned meshes don't: JOINTS_0 is Uint8/Uint16 and WEIGHTS_0 is often quantized, so GLTFLoader requests typed arrays the helper refuses.

Minor: the `outSize` arguments are byte lengths (the helper asserts `num * components * sizeof(T) == out_size`); the README examples read like element counts.

Suggested fix: give the typed path the same `ConvertValue`-based extraction and non-identity mapping support the float path already has. Happy to send a PR.

## Reproducible Demo

Load any Draco-compressed skinned glTF (JOINTS_0 stored as Uint8) through three's GLTFLoader wired to this module. Static meshes decode; the skinned mesh errors on attribute extraction, because `GetAttributeDataArrayForAllPointsHelper` returns `false` unless the stored type and mapping match exactly.

> Transparency note: this issue was drafted with AI assistance. I'm a human, I've personally verified the behavior in the source, and I'm happy to answer any questions or concerns directly. Thanks for the library.

贡献指南

打开贡献指南

调研方向

Start in cpp/draco-helpers.h by comparing GetAttributeDataArrayForAllPointsHelper with GetAttributeFloatArrayForAllPoints, then reproduce the failure using a Draco-compressed skinned glTF with Uint8 JOINTS_0. Done means typed extraction supports conversion and non-identity mapping instead of returning false on mismatches; also check whether the README examples should describe outSize as bytes.

由索引模型根据 Issue 内容生成。

评估

技术栈
cpp, react-native
领域
computer-graphics, mobile-dev
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
描述清楚
新手友好度
68/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。