bytecodealliance / bytecodealliance/wasmtime-dotnet

Multiple C# Threads calling WASM Module

Aperta
#331 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C#
Stelle
519
Fork
67
Merge medio
6h 1m
PR unite (30g)
5

Descrizione

I have tried to run a WASM module from a C# unit test where there are 2 threads calling the module in a loop. This dies with one of the threads ending in with the following exception

**wasm trap: call stack exhausted**

Here is logged output from the Test where

- [n] is the thread number
- Count is the iterations for that thread
- Error Count is whether the result was in error (as I was checking for race conditions)
- Exception is the C# exception that was caught from the WASM method Invoke

```
Debug Trace:
[0] Count: 0 ErrorCount: 0 Exception: error while executing at wasm backtrace:
0: !
1: 0xb25 - !
2: 0x47d8 - !

Caused by:
wasm trap: call stack exhausted
[1] Count: 89498 ErrorCount: 0 Exception:
```

It is like the WASM module method is being called OK by one thread while the other thread is looks to be calling the method but never leaving it and the stack eventually blew up??

If I run this as 1 thread OR put a C# Lock {} block around the WASM method call, then it all runs fine, and I have called the method for over 5,000,000 iterations without an issue.

The WASM module was written in C and and generated using Emscripten. The method takes in two string (pointers) and a an Int64 and returns a string (pointer).

The memory is being Free'ed.

**C method**
char* TryVerify(char* token, char* originHeader, uint64_t serverUtcUnixNowMilliseconds)

**C# call**

```
object lockObject = new object();
public bool TryVerify(string token, string originHeader, out TokenData tokenData)
{
//lock (lockObject)
//{
var serverUtcUnixNowMilliseconds = new DateTimeOffset(DateTime.UtcNow).ToUnixTimeMilliseconds();
int inPtrToken = WriteStringToUTF8(token);
int inPtrOriginHeader = WriteStringToUTF8(originHeader);
int outPtr = _TryVerify.Invoke(inPtrToken, inPtrOriginHeader, serverUtcUnixNowMilliseconds);
var json = Memory.ReadNullTerminatedString(outPtr);
_Free(outPtr);

tokenData = System.Text.Json.JsonSerializer.Deserialize(json, new JsonSerializerOptions() { PropertyNameCaseInsensitive = true }) ?? throw new Exception("Failed to deserialize token data from wasm");
if (tokenData == null)
{
tokenData = new TokenData();
}

return tokenData.IsOk;
// }
}
```

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Inizia riproducendo lo scenario di unit test C# con due thread, quindi confrontalo con un solo thread e con il caso del lock C#. Traccia l'invocazione WASM condivisa, l'allocazione delle stringhe, la lettura della memoria e le chiamate a _Free mostrate in TryVerify. Questo dovrebbe stabilire il comportamento supportato per le chiamate concorrenti e fornire una risoluzione verificata o una limitazione esplicita.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
csharp, wasm
Ambito
backend, testing-qa
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.