browserify / browserify/node-util
circular reference cause `inherits()` became empty object
Abierto
- Lenguaje dominante
- JavaScript
- Estrellas
- 255
- Forks
- 92
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
the line below refs to `inherits()` from `inherits` module, but `inherits` module reference back to `util` module by checking the implementation on `util` module first, causing the first `require('inherits')` to returns empty object (default exports is empty object), if then `util.inherits()` gets call immediately it will throw.
problematic line in question:
https://github.com/browserify/node-util/blame/ef984721db7150f651800e051de4314c9517d42c/util.js#L592
the line needs to be updated to `require('inherits/inherits_browser')`
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Evaluación
Este issue todavía no se ha evaluado.