browserify / browserify/http-browserify
Default protocol is inconsistent with Node's.
- Dominant language
- JavaScript
- Stars
- 245
- Forks
- 104
- PR merge metrics
- No merged PRs in 30d
Description
If not specified, http-browserify sets the protocol to `window.location.protocol`. This differs from the behavior of Node (see https://nodejs.org/api/http.html#http_http_request_options_callback ). I assume the reasoning was to make https requests if the current location is also https (but I could be wrong here).
Does it make sense to mimic Node's behavior exactly, and just default to http: ?
The issue I'm running into is when running a script locally in the browser, so the protocol is "file:". http-browserify then tries to make file:// requests, which obviously fail.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the request-option path that chooses a protocol when none is supplied, and compare its behavior with Node's http.request documentation. Reproduce the issue from a local file:// page and verify that an unspecified protocol defaults to http: rather than file:.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100