browserify / browserify/factor-bundle
Seems to have problems with npm linked dependencies
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 397
- Forks
- 24
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
If I have in my my code say `require("immutable")` and in an `npm link`ed module elsewhere on my system the same require code it gets treated as two different libraries when factored and doesn't end up in the common bundle.
It's odd, and it works fine when not using `npm link`. I can only assume it's something to do with the paths of those files being quite different (ie, when linked it's not in the normal dep tree of the core code).
Frustrating though, especially when dealing with applications that are developed locally with private modules as abstracted parts of the core app. It very much bloats the code.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Start by reproducing the require("immutable") case with an npm-linked module and compare it with the non-linked dependency tree. Trace how factor-bundle identifies shared modules when their paths differ; done means the linked and local copies are recognized as one dependency and placed in the common bundle.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript
- Bereich
- build-system
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 30/100