bramp / bramp/ffmpeg-cli-wrapper

Add support for -i pipe:0

Ouverte
#334 8 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Java
Étoiles
1.9k
Forks
424
Merge moyen
5 h 35 min
PR mergées (30 j)
2

Description

Hello, I need to transcode live videos,
essentially reading from an InputStream and pipeing the output into an OutputStream is what I need to do.
Unfortunately writing the file to disk is not possible for my use case.
I tried using 2 unix sockets which did work for some formats, but some input formats did not work that way. notably the MP4 demuxer
didnt like demuxing from a unix socket. It does however work with demuxing from stdin.

Sadly your CLI wrapper has no support for demuxing from stdin, so I have to rely on ProcessBuilder directly for this one task.

I wouldnt mind developing this as a feature and making a PR to this repo if you are intrested in this.
My idea would be to add a function to FFmpegBuilder that accepts a supplier to a InputStream.
A bit like this:
```
FFmpegBuilder builder = ...
Supplier streamSupplier = ...
builder.setStdIn(streamSupplier)
```

At some appropriate location in the library I would add this code or something similar:
(This may possible require starting of a "background" thread and I will maybe have to make adjustments for java 8 compat.)
```
Supplier streamSupplier = ...
Process proc = ...
if (streamSupplier != null) {
try(OutputStream outputStream = proc.getOutputStream();
InputStream stream = streamSupplier.get()) {
stream.transferTo(outputStream);
}
}

```

After these changes someone could then call
builder.addInput("pipe:0") to pipe the input from the InputStream.
For my usecase the output would still be a unix socket since my output muxer can write to the unix socket
and the input would be from the InputStream.

Tell me if you have any intrest in this feature and I will begin making it and give you a PR shortly.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Commencez par FFmpegBuilder et le point d’entrée de gestion des processus utilisé par le wrapper Java ; examinez comment un fournisseur d’InputStream proposé pourrait alimenter le processus, tandis que addInput("pipe:0") sélectionne stdin. Le travail est terminé lorsque l’entrée en direct peut être diffusée sans écriture sur le disque, en tenant compte de la compatibilité avec Java 8 et en préservant le comportement de sortie existant.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
java
Domaine
cli, tooling
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.