borglab / borglab/gtsfm

Cycle consistency plots are written synchronously (does not work on cluster)

Open
#631 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

Cycle consistency filtering writes plots in the run() method, without any dask.annotate() call to specify which machine to write these plots on. This fails on the cluster because there is no guarantee that the directory to write the plots to will exist on the machine running cycle consistency. Even if there is, the plots will not be obtained on the machine from which gtsfm is run.

https://github.com/borglab/gtsfm/blob/4a9dc6a7ae9a1146b3fc056827b265776921b49c/gtsfm/view_graph_estimator/cycle_consistent_rotation_estimator.py#L137

Contributor guide

Open the contributing guide

Research direction

Start with gtsfm/view_graph_estimator/cycle_consistent_rotation_estimator.py at the run() method near line 137, then inspect how dask.annotate() can specify the machine for plot writing. Done means cycle consistency plots are written reliably on the intended machine and can be obtained from the machine running gtsfm.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization, distributed-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.