borglab / borglab/gtsfm

Use of loader-specific image_filenames() in NetVLAD

Open
#628 0 comments 0 reactions 1 assignee Claimed by @travisdriver View on GitHub
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

image_filenames used in NetVLAD retreiver (for visualization) is not present in all loaders (not a base class member). This will crash if used with a loader that does not have the method.

https://github.com/borglab/gtsfm/blob/581f84ab605e99302a9c6425dc67e38f82b70660/gtsfm/retriever/netvlad_retriever.py#L200

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.