borglab / borglab/gtsfm

Fix two failing unit tests w.r.t. MVS utilities

Open
#413 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

Two tests are failing currently: `TestEllipsoidUtils.test_get_right_singular_vectors` and `TestPatchmatchNetData.test_select_src_views`.

The first is due to the fact that we aren't returning singular values, so we need to correct the terminology. The other test looks like it is flaky due to some random ordering of the output.
```
> assert np.allclose(singular_values, S)
E AssertionError: assert False
E + where False = (array([7.73928148, 2.82711821, 1.20177289]), array([13.40482874, 4.89671238, 2.08153171]))
```

Contributor guide

Open the contributing guide

Research direction

Start by running TestEllipsoidUtils.test_get_right_singular_vectors and TestPatchmatchNetData.test_select_src_views. Inspect the MVS utilities used by those tests to verify the singular-value terminology and investigate the random output ordering. Done means both named unit tests pass reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python
Domain
computer-vision, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.