borglab / borglab/gtsfm

Inlier stats (after checking for support) are incorrect

Open
#399 0 comments 0 reactions 1 assignee Claimed by @ayushbaid View on GitHub
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

Computation in [L82](https://github.com/borglab/gtsfm/pull/225/files#diff-a848c84e1ba3cc26057f1e43c204b0cc1da75f820ca9502823ac2018103de0f5R82) will give us the wrong numbers about inlier stats. If for 3 pairs, we had # inliers as 20, 20, 5, and if we threw away the 3rd, then we should have avg # inliers = 20.

But in our code it would be return as 15, which isn't correct.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.