borglab / borglab/gtsfm

Improvements to make for code quality

Open
#356 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

- Clarify in the HTML report what determines a "valid" image pair

- Have 2 separate thresholds for R and U success? Put in place right before the results against the metric
- Could add image-only metrics before Verifier Summary

- Make a single table for each module (instead of FrontEnd Summary, have Verifier Summary, and PostProcessor Summary)
- There should be a #avg number of inliers w.r.t. est model for Veriifer, and also separately for the PostProcessor
- Create PostProcessor class in accordance with the graph
![Screen Shot 2021-10-18 at 7 01 56 PM](https://user-images.githubusercontent.com/16724970/137817975-04c99c11-1871-4209-8b6a-2747d78b354e.png)

- Decide upon what goes in side-by-side plots when comparing with ground truth
- Should COLMAP # tracks go into COLMAP column? or should it be error w.r.t. COLMAP?

Contributor guide

Open the contributing guide

Research direction

No file, test, or entry point is named. Begin by tracing the HTML report sections, including Verifier Summary, PostProcessor Summary, image-only metrics, and side-by-side ground-truth plots, then review the linked graph for the proposed PostProcessor class. Done requires resolving the listed metric, threshold, table, and plot decisions and implementing the agreed report structure.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
computer-vision, data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.