borglab / borglab/gtsfm

use pixel thresholds relative to image size

Open
#302 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

Make pixel thresholds a function of the image size, to avoid treating 480p and 1296p images differently.

A good reference is http://phototour.cs.washington.edu/ModelingTheWorld_ijcv07.pdf:
We set the RANSAC outlier threshold to be 0.6% of the maximum image dimension, i.e., 0.006 max(image width,image height) (about six pixels for a 1024×768 image).

COLMAP users also complain about how in COLMAP this is hard-coded in their issue #1278.

Contributor guide

Open the contributing guide

Research direction

Start by locating the RANSAC outlier-threshold implementation and its tests; the issue does not name files or entry points. Compare the current fixed threshold with 0.006 × max(image width, image height), then verify behavior across 480p and 1296p images.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
computer-vision
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.