borglab / borglab/gtsfm

Radial coefficients k1, k2 hard-coded to zero when reading values

Open
#301 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

So currently we have k1 and k2 hard coded in different I/O reading files, and as default for EXIF:

https://github.com/borglab/gtsfm/blob/master/gtsfm/common/image.py#L68
https://github.com/borglab/gtsfm/blob/master/gtsfm/utils/io.py#L189

They are also hard-coded to zero when resizing intrinsics. Since they are coefficients of polynomials, a linear rescaling shouldn't be sufficient, though.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.