borglab / borglab/gtsfm

Interface between loaders and `GtsfmData`

Open
#263 2 comments 0 reactions 0 assignees Claimed by @travisdriver View on GitHub
enhancement help wanted
Dominant language
Jupyter Notebook
Stars
524
Forks
64
Avg merge
4h 1m
Merged PRs (30d)
3

Description

this seems like this is a more general purpose function that should go into GtsfmData or something, like

```python
class GtsfmData:
@classmethod
def from_colmap_model(cls, colmap_model_dir: str) -> "GtsfmData":
```
would that make sense?

_Originally posted by @johnwlambert in https://github.com/borglab/gtsfm/pull/258#discussion_r701511870_

Contributor guide

Open the contributing guide

Research direction

The issue names only the loader interface and GtsfmData, with a proposed from_colmap_model class method; no files or tests are identified. Start by locating the existing COLMAP loader and GtsfmData definition, then determine whether the interface belongs on GtsfmData and verify the resulting loader behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.