boostorg / boostorg/python

GCC suggest-override warnings

未關閉
#303 7 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
C++-11 enhancement
主要語言
C++
星號
537
分支
223
平均合併
11 小時 22 分鐘
30 天內合併 PR
2

描述

Complete list of warnings when Boost 1.72 is built with GCC 7.5 with `-Wsuggest-override` added to `cxxflags`:

./boost/python/object/py_function.hpp:102:22: warning: ‘unsigned int boost::python::objects::full_py_function_impl::max_arity() const [with Caller = _object* (*)(_object*, _object*); Sig = boost::mpl::vector1]’ can be marked override [-Wsuggest-override]

./boost/python/object/py_function.hpp:107:46: warning: ‘boost::python::detail::py_func_sig_info boost::python::objects::full_py_function_impl::signature() const [with Caller = _object* (*)(_object*, _object*); Sig = boost::mpl::vector1]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:36:15: warning: ‘PyObject* boost::python::objects::caller_py_function_impl::operator()(PyObject*, PyObject*) [with Caller = boost::python::detail::caller >; PyObject = _object]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:41:22: warning: ‘unsigned int boost::python::objects::caller_py_function_impl::min_arity() const [with Caller = boost::python::detail::caller >]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:46:46: warning: ‘boost::python::detail::py_func_sig_info boost::python::objects::caller_py_function_impl::signature() const [with Caller = boost::python::detail::caller >]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:62:15: warning: ‘PyObject* boost::python::objects::signature_py_function_impl::operator()(PyObject*, PyObject*) [with Caller = _object* (*)(_object*, _object*); Sig = boost::mpl::vector2<_object*, _object*>; PyObject = _object]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:67:22: warning: ‘unsigned int boost::python::objects::signature_py_function_impl::min_arity() const [with Caller = _object* (*)(_object*, _object*); Sig = boost::mpl::vector2<_object*, _object*>]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:72:46: warning: ‘boost::python::detail::py_func_sig_info boost::python::objects::signature_py_function_impl::signature() const [with Caller = _object* (*)(_object*, _object*); Sig = boost::mpl::vector2<_object*, _object*>]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:92:15: warning: ‘PyObject* boost::python::objects::full_py_function_impl::operator()(PyObject*, PyObject*) [with Caller = _object* (*)(_object*, _object*); Sig = boost::mpl::vector1; PyObject = _object]’ can be marked override [-Wsuggest-override]
./boost/python/object/py_function.hpp:97:22: warning: ‘unsigned int boost::python::objects::full_py_function_impl::min_arity() const [with Caller = _object* (*)(_object*, _object*); Sig = boost::mpl::vector1]’ can be marked override [-Wsuggest-override]

Depends on boostorg/config#329.

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

Start with boost/python/object/py_function.hpp and inspect the declarations at the warning lines listed in the report. Check boostorg/config#329 first, then build Boost 1.72 with GCC 7.5 and -Wsuggest-override; done means the reported warnings are resolved without introducing new build failures.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
cpp, python
領域
backend, build-system
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。