boostorg / boostorg/graph

Vertex property `vertex_index_t` silently discarded when `vecS` selector used vertex list

Aperta
#420 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
data structure priority: low
Lingua principale
C++
Stelle
392
Fork
239
Merge medio
1g 11m
PR unite (30g)
20

Descrizione

As in the title.

Consider the following code

```cpp
#include
#include
#include
#include

typedef int v_index;
typedef long e_index;

typedef boost::adjacency_list<
boost::vecS, // OutEdgeList
boost::vecS, // VertexList
boost::undirectedS, // DirectedS
boost::property, // Vertex property.
boost::no_property, // Edge property (can be enhanced if needed).
boost::no_property, // Graph property.
boost::vecS // EdgeList
> Graph;

typedef boost::property_map::type vertex_to_int_map;

static_assert(std::is_same_v,
"The vertex property map's value type must be v_index");
```

The static assertion fails. Changing `VertexList` to e.g. `boost::listS` makes it pass.

This causes a little problem in generic code which assumes the type returned by the `vertex_to_int_map` property map is equal to `v_index`. For example https://github.com/sagemath/sage/pull/39526 .

Not sure what's the best course of action here. I think the easiest one would be to make the property map just cast the result to the correct type (assume it can be casted of course, but what if the user specifies something weird like `std::string`?)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.