boostorg / boostorg/graph

Vertex property `vertex_index_t` silently discarded when `vecS` selector used vertex list

Open
#420 1 comment 0 reactions 0 assignees View on GitHub
data structure priority: low
Dominant language
C++
Stars
392
Forks
239
Avg merge
1d 11m
Merged PRs (30d)
20

Description

As in the title.

Consider the following code

```cpp
#include
#include
#include
#include

typedef int v_index;
typedef long e_index;

typedef boost::adjacency_list<
boost::vecS, // OutEdgeList
boost::vecS, // VertexList
boost::undirectedS, // DirectedS
boost::property, // Vertex property.
boost::no_property, // Edge property (can be enhanced if needed).
boost::no_property, // Graph property.
boost::vecS // EdgeList
> Graph;

typedef boost::property_map::type vertex_to_int_map;

static_assert(std::is_same_v,
"The vertex property map's value type must be v_index");
```

The static assertion fails. Changing `VertexList` to e.g. `boost::listS` makes it pass.

This causes a little problem in generic code which assumes the type returned by the `vertex_to_int_map` property map is equal to `v_index`. For example https://github.com/sagemath/sage/pull/39526 .

Not sure what's the best course of action here. I think the easiest one would be to make the property map just cast the result to the correct type (assume it can be casted of course, but what if the user specifies something weird like `std::string`?)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.