boostorg / boostorg/build

Potential memory leak in file_collect_archive_content_

Aperta
#325 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
transition
Lingua principale
C++
Stelle
251
Fork
63
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

https://github.com/boostorg/build/blob/0c6d016/src/engine/fileunix.c#L324 performs a memory allocation which has a chance of leaking when processing a corrupt archive.

In the unlikely situation where an archive has two string tables (or simply one string table and another entry with a name that starts with `//`) there will be a second allocation and the original value of `string_table` will be leaked.

This probably isn't worth fixing, I'm only reporting it because Coverity flags it as a leak. If you do want to make any change then it's probably enough to just do something like:

assert(!string_table);

before the allocation.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.