boostorg / boostorg/beast

Documentation does not mention stack requirements

Aperta
#844 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Design Doc
Lingua principale
C++
Stelle
4.8k
Fork
694
Merge medio
12h 48m
PR unite (30g)
1

Descrizione

```read``` or ```async_read``` operations may require "large" amounts of stack. The documentation should acknowledge this.

Example: https://github.com/boostorg/beast/blob/ffbe65f4c922e1b8d76e85434d0a8d3ee1c083e9/include/boost/beast/http/impl/basic_parser.ipp#L486
If the parser is used inside of a stackful coroutine, this may easily lead to stack overflow. A coroutine stack size is architecture dependent and the user may choose a size that is smaller than the default(64k IIRC), but the size should be at least ``` SIGSTKSZ```, which happens to be ```8196``` bytes on linux-amd64.

Additional related thing to consider: with split stacks enabled a large stack allocation might not necessarily improve performance over a dynamically allocated buffer.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.