boostorg / boostorg/array

Warning: "Possible misuse of comma operator"

Open
#12 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
24
Forks
55
PR merge metrics
No merged PRs in 30d

Description

I'm seeing a warning being emitted by this library when I'm using Xcode 10.3:

https://github.com/boostorg/array/blob/92f66a9f14ca1eef03b6028b01a1cab05e989991/include/boost/array.hpp#L185

> Possible misuse of comma operator here

![image](https://user-images.githubusercontent.com/192418/93354305-2410dd80-f83d-11ea-9c03-8f0a637bd472.png)

Initially I thought of making a PR to address it, but I don't really understand the expression at that line. Why is `boost::throw_exception` followed by `, true` ?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with include/boost/array.hpp at line 185 and inspect the surrounding expression and its uses. Check how the comma expression interacts with boost::throw_exception and why Xcode 10.3 reports it; done means the warning is addressed without changing the expression's intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.