bluerobotics / bluerobotics/ping-viewer

Firmware patch versions are not shown

Open
#1,083 0 comments 0 reactions 0 assignees View on GitHub
enhance good first issue nice-to-have
Dominant language
C++
Stars
64
Forks
47
PR merge metrics
No merged PRs in 30d

Description

## Summary
The [`device_information`](https://docs.bluerobotics.com/ping-protocol/pingmessage-common/#4-device_information) message includes a field for the firmware patch version, and some of [our firmwares](https://github.com/bluerobotics/ping-firmware) (Ping2 / Ping360) are named using them, but we don't currently show them in the "Current Firmware" indicator when flashing, or in the general debug window (we only show `major.minor`, not the full `major.minor.patch`.

## Additional information

Screenshot 2024-06-12 at 5 34 26 AM

Raised in [this PR comment](https://github.com/bluerobotics/ping-viewer/pull/1081#pullrequestreview-2110984746)

Contributor guide

Open the contributing guide

Research direction

Start by tracing the device_information message into the Current Firmware indicator and the general debug window. Check where the firmware version is formatted, then verify that both displays include major.minor.patch for firmware that provides a patch version.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.