bluerobotics / bluerobotics/ping-viewer
Flashing firmware with a new device type does not get reflected in the current session
- Dominant language
- C++
- Stars
- 64
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Description
## Summary
**Version:** 2.5.1
**Operating System:** Mac (Sonoma) - most likely all OSs
**What is happening:** Flashing a Ping1D device with a different device type (Ping vs Ping2) does not get reflected in the Automatic Update version filtering until Ping Viewer gets restarted. Most likely the device information does not get re-checked until it's registered as a new connection to the device.
**How to reproduce it:** Manually flash a Ping1D device with the opposite device type (e.g. from `Ping-V3.29_auto.hex` to `Ping2-V1.1.0_auto.hex`), and notice that the firmware flasher does not update to show firmwares for the new device type in the Automatic Update section, but instead still shows firmwares for the previous device type (e.g. Ping -> Ping2 will still show Ping firmwares).
## Additional information
- Originally raised in [this PR comment](https://github.com/bluerobotics/ping-viewer/pull/1081#pullrequestreview-2110984746)
- Technically a bug, but not a critical issue - users are not expected to change the device type by flashing the incorrect firmware onto a device that happens to have the same chip as a different device, and if they end up having done so then it seems ok if there are some minor inconveniences during the recovery
Contributor guide
Research direction
Start by tracing the firmware flasher's Automatic Update filtering and the device registration or session-refresh path described in the issue. Reproduce a Ping-to-Ping2 firmware change and verify that the available firmware list updates to the new device type without restarting Ping Viewer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100