bluerobotics / bluerobotics/ping-python
Omniscan 450: Cannot change speed of sound. Wrong message id.
- 主要语言
- Python
- 星标
- 60
- 派生
- 39
- PR 合并指标
- 30 天内没有已合并 PR
描述
_This is my first issue/PR on open-source code. I used AI to navigate the process but have manually reviewed to the best of my knowledge._
> The core issue stems from the [ping-protocol](https://github.com/bluerobotics/ping-protocol/issues/222) repository. Issue is opened there too.
## Description
The `set_speed_of_sound` message for OMNISCAN450 sonar is defined with message ID 1002
in `src/definitions/omniscan450.json`, but the device expects ID 116.
This can be deducted from the documentation here: https://docs.ceruleansonar.com/c/omniscan-450/application-programming-interface.
## Expected Behavior
When setting speed of sound on OMNISCAN450, the library should use message ID 116.
## Current Behavior
Library sends/expects ID 1002, causing the device to ignore the message (returns a 'not-acknowledged'/NACK response)
## Steps to Reproduce
1. Create OMNISCAN450 instance
2. Call set_speed_of_sound() method
3. Device does not update speed of sound (ignores command)
## Environment
- Device: Cerulean Omniscan450 FS
- Library: bluerobotics-ping (latest)
- OS: Ubuntu (WSL 2)
## Severity
High - breaks core feature (speed of sound configuration)
## Proposed Solution
Change `omniscan450.json` `set_speed_of_sound` ID from 1002 to 116.
Two PR's have been created;
- https://github.com/bluerobotics/ping-protocol/pull/221: fixes the core issue in the omniscan450.json file in the ping-protocol repository.
- https://github.com/bluerobotics/ping-python/pull/170: ensures the fix in the ping-protocol repository will be propagated to the ping-python package.
贡献指南
这个仓库没有索引到贡献指南
调研方向
Start with src/definitions/omniscan450.json in the linked ping-protocol repository and review ping-protocol PR #221, then see how ping-python PR #170 propagates the change. Done means the OMNISCAN450 set_speed_of_sound operation uses message ID 116 and the device no longer returns a NACK.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- api
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 25/100