bluerobotics / bluerobotics/ping-python

avoid using print() function

Aperta
#141 2 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
60
Fork
39
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

This is just a copy of connect_serial() method from brping/device.py (ver 0.1.5)

```py
def connect_serial(self, device_name: str, baudrate: int =115200):
if device_name is None:
print("Device name is required")
return

try:
print("Opening %s at %d bps" % (device_name, baudrate))

## Serial object for device communication
# write_timeout fixes it getting stuck forever atempting to write to
# /dev/ttyAMA0 on Raspberry Pis, this raises an exception instead.
self.iodev = serial.Serial(device_name, baudrate, write_timeout=1.0)
self.iodev.send_break()
time.sleep(0.001)
self.iodev.write("U".encode("ascii"))

except Exception as exception:
raise Exception("Failed to open the given serial port: {0}".format(exception))
```

The request here is:
Kindly avoid using the `print` function in a library like this. If the device name is required, it should be handled as an exception, not with a `print` and `return`:

```py
raise ValueError("Device name is required")
```

And the next `print` is indeed a logging:

```py
logger.info("Opening %s at %d bps", device_name, baudrate)
```

I've had to use workarounds to prevent these `print`s from being sent to my app's stdout:

```py
def brping_muted_print(*args, **kw):
if len(args) == 1:
args = args[0]
log('brping: %s', args)
# brping module uses raw print statements for logging
# with this trick, we turn them into proper logs
brping.device.print = brping_muted_print
```

Thanks

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.