bluerobotics / bluerobotics/ping-python

Add `set_range` functionality for Ping360

Abierto
#122 1 comentario 1 reacción 1 asignado Reclamado por @ES-Alexander Ver en GitHub
enhancement
Lenguaje dominante
Python
Estrellas
60
Forks
39
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Details discussed in a forum post:

> [@[EliotBR](https://discuss.bluerobotics.com/t/ping-sonar-range-setting-and-the-angle-definition/11686/2)]
>> [@[yuki](https://discuss.bluerobotics.com/t/ping-sonar-range-setting-and-the-angle-definition/11686)]
>> Can an effective range be set up in [ping360.py](https://github.com/bluerobotics/ping-python/blob/deployment/brping/ping360.py)?
>
> The range per sample is determined by the `sample_period` , so the total range is determined by `sample_period` and `number_of_samples` , together with the [speed of sound](https://docs.bluerobotics.com/ping-viewer/device-settings-ping360/#:~:text=Speed%20of%20Sound,and%20salinity%20levels.) in the water you’re operating in (see [here](https://github.com/bluerobotics/ping-viewer/issues/1003) if you want to estimate it from vehicle data, and [here](https://bluerobotics.com/learn/speed-of-sound-in-water-calculator#salinity-estimation) for estimating salinity).
>
> If you want to make a `set_range` function, it may be worth looking at [how it’s implemented in Ping Viewer](https://github.com/bluerobotics/ping-viewer/blob/master/src/sensor/ping360.h#L176-L203) 🙂

Speed of sound could either be set at the start (most user-friendly), or specified in the `set_range` function call (slightly simpler to implement)

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.