bluerobotics / bluerobotics/ping-protocol

calculate_checksum function does not check for 16b value

Open
#130 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
27
Forks
26
PR merge metrics
No merged PRs in 30d

Description

```
def calculate_checksum(self):
checksum = 0
for byte in self.msg_data[0:PingMessage.headerLength + self.payload_length]:
checksum += byte
// need to add checksum &= 0xffff
return checksum
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.