bluerobotics / bluerobotics/cockpit

Add a proper popup in configuration joystick menu that does not close the whole menu when the vehicle is automatically disarmed

Open
#785 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue ux
Dominant language
TypeScript
Stars
198
Forks
63
Avg merge
2d 7h
Merged PRs (30d)
57

Description

> Currently no alert popup is shown when the joystick configuration view is opened and vehicle is automatically disabled, we could add a Swal alert but when the user either interact with it or press ESC it will close the configuration menu itself due to it being listen to these events, so in this case we would need to change this behavior, or maybe auto close the popup

I would say that auto-closing the popup would be enough for now, but the reality is that if the popup appears, there's a high risk of the user clicking outside it to close it and (I think) that will close the config menu also, so I would say for us to do the right way and put a close button. Can you open an issue to track that for a following PR?

_Originally posted by @rafaellehmkuhl in https://github.com/bluerobotics/cockpit/issues/784#issuecomment-1969227273_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start from the joystick configuration view and trace the Swal alert behavior described in the issue, including how ESC and outside clicks are handled by the configuration menu. Done means the automatic-disarm popup has an explicit close button and dismissing it does not close the configuration menu; no file or test paths are named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.