bluerobotics / bluerobotics/cockpit

Video stats overlay shows no resolution for H.265 RTSP cameras

Open
#2,969 0 comments 0 reactions 1 assignee Claimed by @rafaellehmkuhl View on GitHub
ui video
Dominant language
TypeScript
Stars
198
Forks
63
Avg merge
2d 7h
Merged PRs (30d)
57

Description

`parseResolutionFromSdp` (`src/electron/services/go2rtc.ts:212`) matches `sprop-parameter-sets=`, which is the H.264 form. An H.265 producer's SDP carries `sprop-vps`/`sprop-sps`/`sprop-pps` instead, so the regex never matches and `parseH264SpsResolution` is never reached.

The result is that `Go2RTCStreamInfo.width`/`height` come back undefined and the "Size" row of the stats-for-nerds overlay (`src/components/VideoPlayerStatsForNerds.vue:141`) renders `...` indefinitely for those cameras.

This has always been the case, but is only becoming reachable now with the H.265 support (#2967). Fix would be parsing the H.265 SPS out of `sprop-sps` for HEVC producers.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.