bluerobotics / bluerobotics/blueberry-transcode-firmware
Too much bounds checking
- Dominant language
- C
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Currently bounds checking is done in the bbWrap function in blueberry-transcoder.c
This is called in getBbUint8, setBbUint8 and setBbBool
These are then called multiple times in the multi-byte word accessors.
This is super wasteful. It would be better to check prior to the top-level accessor and then call a lower level non-checked byte accessor.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in blueberry-transcoder.c with bbWrap, getBbUint8, setBbUint8, and setBbBool, then trace how the multi-byte word accessors call them. Move bounds checking to the top-level accessor path and use a lower-level non-checked byte accessor so each operation is checked only once.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100