bluerobotics / bluerobotics/BlueOS

Allow streaming uploaded docker images to disk

Open
#3,705 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Vue
Stars
453
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
174

Description

Originally raised by @Williangalvani in [this comment](https://github.com/bluerobotics/BlueOS/issues/1600#issuecomment-3114346458), with some additional [relevant discussion](https://github.com/bluerobotics/BlueOS/pull/3435#discussion_r2226790926) from elsewhere.

Currently version chooser downloads the user's full uploaded file to memory on the onboard computer, before saving it to disk, which can then run into memory issues with the running BlueOS container.

As of #3646 this may technically also be a problem for Kraken, but if the user can't load a compressed tar file of their Extension into memory then it's very unlikely they can run the actual Extension either, so it's unlikely to be a specific pain point there.

Kraken does at least seem to [stream the extraction and image loading of the downloaded tar file](https://github.com/bluerobotics/BlueOS/pull/3646/changes#diff-0e2a2790e842367159ec4579b85958fba6074b2f65134d3b1e992b1e26316238R443), in case that's relevant (it seems version chooser [does not do the same](https://github.com/bluerobotics/BlueOS/blob/3c3d65833feca0d47cdab2132a5e3818afdb298e/core/services/versionchooser/utils/chooser.py#L87), which Willian has also [commented about](https://github.com/bluerobotics/BlueOS/issues/1503#issuecomment-1444201248)).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.