bluerobotics / bluerobotics/BlueOS

[core] Extract subprocess calls into a function

Open
#3,194 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Vue
Stars
453
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
174

Description

Since we are using more and more of this, with slightly different parameters, we would benefit from having it extracted into an ergonomic function to guarantee a coherent code to these critical parts of the system logic.

> I think we can extract this into a function and share this code with [`core/services/autopilot_manager/mavlink_proxy/AbstractRouter.py:AbstractRouter::start`](https://github.com/bluerobotics/BlueOS/blob/1d6851042c65aea0fc893a7741140358d36ee6a9/core/services/ardupilot_manager/mavlink_proxy/AbstractRouter.py#L96) and [`core/services/helper/main.py:ping`](https://github.com/bluerobotics/BlueOS/blob/1d6851042c65aea0fc893a7741140358d36ee6a9/core/services/helper/main.py#L634).

_Originally posted by @joaoantoniocardoso in https://github.com/bluerobotics/BlueOS/pull/3154#discussion_r1983753501_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading AbstractRouter::start in core/services/ardupilot_manager/mavlink_proxy/AbstractRouter.py and ping in core/services/helper/main.py, then locate the existing subprocess calls in both entry points. Determine which parameters and behavior they share. Done means the repeated calls use one ergonomic shared function with coherent handling across these critical paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.