bluerobotics / bluerobotics/BlueOS
core: frontend: NMEA Injector should support specifying a GPS ID
- Dominant language
- Vue
- Stars
- 453
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 174
Description
### Current behaviour
[The message supports the field](https://github.com/bluerobotics/BlueOS/blob/master/core/services/nmea_injector/nmea_injector/MavlinkNMEA.py#L49), but [we're currently not specifying it](https://github.com/bluerobotics/BlueOS/blob/master/core/services/nmea_injector/nmea_injector/MavlinkNMEA.py#L69-L88), which may make filtering of separate GPSs harder for receivers (although in principle MAVLink GPSs should also be separated [by component ID](http://mavlink.io/en/messages/minimal.html#MAV_COMPONENT:~:text=220,GPS%20%232.), which we do allow specifying).
Raised in [this forum thread](https://discuss.bluerobotics.com/t/topside-location-in-cockpit/17398).
### Expected or desired behaviour
The NMEA Injector service should be updated to include a GPS ID field for each configured NMEA socket.
That may also be usable to automatically set the relevant [`GPS_TYPEn`](https://docs.bluerobotics.com/ardusub-zola/software/autopilot/ArduSub-4.1/developers/parameters/#gps-type-1st-gps-type) parameter in the autopilot to MAVLink, which could resolve/help #2516.
### Prerequisites
- [X] I have checked to make sure that a similar request has not already been filed or fixed.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.