bluerobotics / bluerobotics/BlueOS

core: frontend: vehicle-setup: support BlueBoat (Rover) NavLight configuration

Open
#2,374 0 comments 0 reactions 0 assignees View on GitHub
core enhancement ui
Dominant language
Vue
Stars
453
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
174

Description

### Current behaviour

We have lights configuration for ArduSub already, and it would be nice to have something similar for the NavLight on the BlueBoat. The light is currently controlled by flash patterns defined in a Lua script (#2372 is relevant), but given it's a standard component on a common BlueOS vehicle type we should be able to have a more intuitive control interface for it.

### Expected or desired behaviour

We should support configuration of [the timings](https://github.com/bluerobotics/Blueos-Parameter-Repository/pull/3/files#diff-2aa6fdceb4de7764a34c29ee1e3361fecfc2595f81b55dbd685cc98882ea5b73R61-R73), which could just modify the underlying file, potentially also with an override option for something completely custom.

A few interface ideas:
1. an exaggerated graph view, with the controllable parameters editable on the graph:
- table style options:
image
- combined graph:
image
1. a cycle graph with the parameters defined inside it, with the pulse timings to scale:
- table style:
image
- gallery style:
image
- this could also have the relative diameters scaled based on the relative periods, but I'm not sure if that would look messy
- the dotted inner circle shows the "off" level, so it's clear when a pattern is fully on or fully off

**Notes:**
- We should include input validation on whether the specified flash sequence can fit within the cycle period
- Brightness control would also be nice (using multiple shorter pulses)
- Would require a more advanced script
- I'm not sure whether the update function is run fast enough for it to be practical
- This interface could either be in its own special NavLight page, or it could live within the Notifiers page (#2373)

### Prerequisites

- [X] I have checked to make sure that a similar request has not already been filed or fixed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.