blakeembrey / blakeembrey/javascript-stringify
Repeated references in Maps & Sets produce broken output
- Dominant language
- TypeScript
- Stars
- 146
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Briefly, this happens:
```js
const obj = {}
const map = new Map([['a', obj], ['b', obj]])
const ok = stringify(map)
// "new Map([['a',{}],['b',{}]])"
const bad = stringify(map, null, null, { references: true })
// "(function(){var x=new Map([['a',{}],['b',undefined]]);x[1][1]=x[0][1];return x;}())"
eval(bad)
// Uncaught TypeError: Cannot read property '1' of undefined
```
The problem here is that the object type isn't tracked, and therefore isn't taken into account by `stringifyPath`. The `.` and `[]` forms work fine for arrays and objects, but don't for Maps and Sets. The path in those cases is referring to the `Array.from()` constructions, rather than the resulting objects.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with stringifyPath and the Map/Set handling exercised by the provided stringify(..., { references: true }) reproduction. Trace how paths are built from Array.from() and verify that eval(bad) succeeds while repeated references remain preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100