bitcoindevkit / bitcoindevkit/rust-electrum-client

Fix unreproducible tests

Aperta
#142 3 commenti 0 reazioni 1 assegnatario Rivendicata da @oleonardolima Vedi su GitHub
tests
Lingua principale
Rust
Stelle
89
Fork
82
Merge medio
2g 3h
PR unite (30g)
1

Descrizione

> The tests are CRAZY! They are even not reproducible. They pretty much ping a live server `electrum.blockstream.info:50001`. So I added the tests for the fees to make sure that the fee is `> 0`.

Maybe we should switch to use a local regtest electrs that we pre-populate with a certain amount of transactions and blocks to make them ~reproducible? Or, we could consider building a mock Electrum server, which shouldn't be hard to do? Especially given the confusion around fee rate conversion it would be good to test it properly in CI?

_Originally posted by @tnull in https://github.com/bitcoindevkit/rust-electrum-client/issues/136#issuecomment-2275080407_

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.