bitcoindevkit / bitcoindevkit/rust-electrum-client

Fix unreproducible tests

Open
#142 3 comments 0 reactions 1 assignee Claimed by @oleonardolima View on GitHub
tests
Dominant language
Rust
Stars
89
Forks
82
Avg merge
2d 3h
Merged PRs (30d)
1

Description

> The tests are CRAZY! They are even not reproducible. They pretty much ping a live server `electrum.blockstream.info:50001`. So I added the tests for the fees to make sure that the fee is `> 0`.

Maybe we should switch to use a local regtest electrs that we pre-populate with a certain amount of transactions and blocks to make them ~reproducible? Or, we could consider building a mock Electrum server, which shouldn't be hard to do? Especially given the confusion around fee rate conversion it would be good to test it properly in CI?

_Originally posted by @tnull in https://github.com/bitcoindevkit/rust-electrum-client/issues/136#issuecomment-2275080407_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.