biocore / biocore/microsetta-private-api
Retired Surveys Didn't Break Integration Test
- Dominant language
- Python
- Stars
- 6
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
We retired the Migraine, Surfer, and COVID-19 surveys from the normal survey flow with the relaunch of TMI. However, they have remained in the `bobo_takes_all_local_surveys` integration test (https://github.com/biocore/microsetta-private-api/blob/master/microsetta_private_api/api/tests/test_integration.py#L662), and that has continued to pass, which seems like unintended behavior. This should be assessed and the survey template code and/or the integration test should be adjusted to ensure that we're testing both the addition and removal of local surveys.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with microsetta_private_api/api/tests/test_integration.py around bobo_takes_all_local_surveys and compare its expected surveys with the retired Migraine, Surfer, and COVID-19 surveys. Then inspect the survey template code to determine whether those surveys remain in the normal flow. Done means the relevant code and/or test covers both adding and removing local surveys, and the integration test exposes unintended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100